Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): generate correct user key range in iter_log #17805

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jul 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously we use Bound::map to create the user key range from table key range. However, when table key range has Unbounded bound, the user key range will also be unbounded, which may include keys from other table_id. In this PR, we generate the user key range by bound_table_key_range, which is the same as iter.

Some refactor on log store epoch are included by the way.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 requested review from hzxa21 and xxhZs July 24, 2024 10:58
@github-actions github-actions bot added the type/fix Bug fix label Jul 24, 2024
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@wenym1 wenym1 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit a9859ed Jul 31, 2024
29 of 30 checks passed
@wenym1 wenym1 deleted the yiming/iter-log-fix-user-key-range branch July 31, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants